fix Bun.spawn empty args #14074
Open
fix Bun.spawn empty args #14074
+20
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sorry about this. I made some changes which hopefully addresses this - 6e0847c |
|
@Jarred-Sumner Thank you so much <3 I'll try again to build the code when I have time, and see about testing the ideas from this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes
Bun.spawnHow did you verify your code works?
After spending 2, or 3 hours trying to figure out how to compile this code on Linux I gave up. The CONTRIBUTING.md is very out of date, and eventually I got close to making it build, but it seems that if you remove the lld linker plugin (I didn't seem to have it working for some reason) that a truck load of undefined symbol complaints come from the linker.
Hopefully, someone can take my idea, fix it and merge it 😢. I tried pretty hard to make this work.